chore: spacing tweaks #698
Conversation
- make paragraph breaks less spacey - move `ul` closer to the preceeding paragraph which gives more visual clarity of where it belongs to - give code blocks a bit more space at the top/bottom on larger screens - give blockquotes more space at the top/bottom on larger screens Combined, these changes give more visual clarity of which things belong together, which stand on its own, etc
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -376,7 +380,7 @@ | |||
| li::before { | |||
| content: ''; | |||
| position: absolute; | |||
| top: 1.43rem; | |||
| top: 1.1rem; | |||
There was a problem hiding this comment.
this looks bad on my screen. we will need to find some approach that works across different configurations
There was a problem hiding this comment.
pushed something, let me know if that works for you
There was a problem hiding this comment.
saw you pushed something, how does that differ to the line-height dependent solution for you? can't we tweak the calc a bit?
FWIW I'm fine with your solution, it's already much better than what we currently have
There was a problem hiding this comment.
It didn't work across the board for me, and I figured if everything is the same units we don't need a calc. Obviously em and lh are fungible, but the way I'm thinking of it is this: lh for spacing in typography, em for things that are tied to the size of the type itself (like icons), rem for layout. We're not being totally disciplined but I think that's a sensible way to think about things
Co-authored-by: Rich Harris <[email protected]>
ulcloser to the preceeding paragraph which gives more visual clarity of where it belongs toCombined, these changes give more visual clarity of which things belong together, which stand on its own, etc