-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync docs (by copying them) #69
Conversation
This implements a different approach to syncing the docs. Rather than creating a toolchain that requires git sync or similar on build and keeps things transient, this approach implements a script that is invoked separately (and can be part of a github action for example) that mostly copies the documentation from the target repositories over into the omnisite, while also invoking scripts for creating the generated reference docs. The result is saved to disk, which has a few advantages: - build is massively simpler: no dependencies on flaky git or other remote sources, as everything is already there - getting started is easier, no need to sync first, just checkout the repo and go. This is especially helpful if you're working on the site itself, not the content - translations will be easier: just don't invoke the sync script, instead modify the directories by hand. Keeping up to date with the source will also be easier because you can git-diff changes to docs At the same time, this lays the foundation for versioning; kit and svelte docs are both inside a v02/v05 directory (leading 0 to not muss up ordering once we're in double digits)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I see |
It's doing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm onboard with this approach and having thought about things – is the most scalable approach for us right now.
Alternative to #55
Closes #20
This implements a different approach to syncing the docs. Rather than creating a toolchain that requires git sync or similar on build and keeps things transient, this approach implements a script that is invoked separately (and can be part of a github action for example) that mostly copies the documentation from the target repositories over into the omnisite, while also invoking scripts for creating the generated reference docs. Detailed steps:
pnpm sync-docs
triggers sync script (can be invoked locally, from a github action, whatever)Running the build (i.e. building the site using the committed content and the app code) can then be done separately.
Because the result is saved to disk, and syncing and building are split, we get a few advantages:
At the same time, this lays the foundation for versioning; kit and svelte docs are both inside a v02/v05 directory (leading 0 to not mess up ordering once we're in double digits). Versioning is implemented in follow-up PR in #70.