-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add devtools updates #673
Conversation
Can you add a comment to the code explaining why we need this? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Added a comment on top of the file. I haven't really thought of other plans for |
What happens if we're rate-limited (or the request fails for some other reason) as we're trying to prerender? Note also that this won't update when the tags update, only when the tags update and we've redeployed the site, which depending on what other activity is happening could be a long delay. We could try making it an ISR route? Otherwise I think it has to live elsewhere |
The tags not updating until we redeploy the site is a concern indeed, I thought it'd be fine for users to wait but it could theoretically take days or weeks before the site is redeployed. Making this an ISR route seems to be the sweet spot, rate limits shouldn't be a concern as GH allows 60 reqs/h — unless I'm mistaken about how ISR works and it only caches for each unique IP requests? Which.. I haven't thought about how to tackle in that case This update manifest needs to be hosted under |
Converted it to an ISR route, checked and it works perfectly! It will revalidate every 5 minutes, so we should stay comfortably under rate limits. |
Originally from sveltejs/svelte-devtools#213
Prerequisite for sveltejs/svelte-devtools#207