Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless (i think?) try-catch #40

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

i've no idea what this err.data stuff was about but it doesn't seem very useful — we should probably just let sveltekit's normal error handling deal with it

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 1:32pm

@dummdidumm
Copy link
Member

The slight difference would be that previously it returned whatever was inside the data property. I have no idea if that is in any way useful/necessary, so I'm inclined to agree that we can just remove the try-catch.

@Conduitry
Copy link
Member

Is the contents of the data property going to be some oauth2 error? Is that going to be getting logged somewhere else, if it's no longer going to be returned in the HTTP response?

@Rich-Harris
Copy link
Member Author

Honestly no idea what data is, which by itself feels like a good reason to not just lob it at the client. I would hope that the error message (which would get logged) contains enough information to start diagnosing

@Rich-Harris Rich-Harris merged commit 77de65f into main Jun 20, 2024
2 of 3 checks passed
@Rich-Harris Rich-Harris deleted the remove-useless-try-catch branch June 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants