Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: add cli docs #293

Merged
merged 17 commits into from
Oct 28, 2024
Merged

draft: add cli docs #293

merged 17 commits into from
Oct 28, 2024

Conversation

manuel3108
Copy link
Member

Goes with: sveltejs/cli#71

Since we don't have our types in the same place, i needed to create a new property. But I don't think that's too bad.

Copy link

vercel bot commented Oct 8, 2024

@manuel3108 is attempting to deploy a commit to the Svelte team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @manuel3108 as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @manuel3108 as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Svelte team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

@Rich-Harris
Copy link
Member

If you click the 'details' link here, I can add you to the svelte team on Vercel so that you'll be able to trigger and view preview deployments

image

@manuel3108
Copy link
Member Author

Done

Copy link

vercel bot commented Oct 9, 2024

An owner of the Svelte Team on Vercel accepted @manuel3108's request to join.

@manuel3108's commit is now being deployed.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ❌ Failed (Inspect) Oct 28, 2024 6:23pm
svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 6:23pm

@Rich-Harris
Copy link
Member

Tweaked the sync-docs script to try and get syncing working properly but we're not there yet — it fails because dist/index.d.ts isn't checked in. For Svelte and Kit we do check types in, partly because it helps with stuff like this but partly because it prevents accidental breakage, so I reckon we should do the same thing here.

I can work directly on the chore/add-docs branch if it's cool with you

@manuel3108
Copy link
Member Author

Sure, go ahead!

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per @benmccann, we need to hold off on merging this until we're ready to talk about sv publicly

@Rich-Harris
Copy link
Member

By the same token I'll hold off on any further docs changes until later. That'll give us time to resolve some outstanding questions:

@benmccann
Copy link
Member

Yes, even post-launch lets take our time with pushing the docs out so that we can get this stuff right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants