Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use rollup web worker for Svelte tutorial #207

Merged
merged 37 commits into from
Oct 4, 2024
Merged

feat: use rollup web worker for Svelte tutorial #207

merged 37 commits into from
Oct 4, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Oct 1, 2024 •
edited
Loading

Enhances the adapter to load the rollup web worker for the regular Svelte tutorial, as it's faster, more robust and works on mobile iOS.

Notes:

  • deliberately resisting some refactorings around legacy->runes mode etc to keep the diff manageable
  • in general could use a closer look after 5.0 to assess how things are pieced together; not now to get this out in time

Still todo:

  • make switching back and forth between Rollup and SvelteKit windows more robust
  • integrate the rollup output console into the terminal icon instead of having inconsistent UI
  • assets no longer be served through the web container, possibly needs to go through our github assets repo again

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 7:05pm

@dummdidumm
Copy link
Member Author

This is basically done, the majority of my time is now taken up by trying to figure out how to properly configure the headers for assets, FML

@Rich-Harris
Copy link
Member

Does the audio work for you in /tutorial/media-elements and /tutorial/module-exports? For me it doesn't do anything until I interact with the progress bar. I don't know if this is a quirk of cross-origin isolation (I get an empty 206 response initially) or a bug in Svelte

@Conduitry
Copy link
Member

It looks like this PR maybe also fixes the Svelte Origins clip on the homepage? That's broken for me currently on main due to a Cross-Origin Resource Policy issue.

@dummdidumm
Copy link
Member Author

Does the audio work for you in /tutorial/media-elements and /tutorial/module-exports?

It does not, and it also does not on main. Not sure what the source of the problem is (I almost hope Svelte itself)

@Rich-Harris
Copy link
Member

I almost hope Svelte itself

I think we're in luck, I can reproduce this in the sandbox. I think that toggling paused doesn't cause the audio to play. Looking into it

@Rich-Harris
Copy link
Member

sveltejs/svelte#13502

@Rich-Harris
Copy link
Member

Are you on top of the Silian Rail thing or shall I take care of that? I think it's the last thing

@Rich-Harris Rich-Harris merged commit 70bf98d into main Oct 4, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the rollup-tutorial branch October 4, 2024 19:07
@Rich-Harris
Copy link
Member

amazing work!

dummdidumm added a commit that referenced this pull request Oct 4, 2024
@dummdidumm
remove css which is loaded from other place
e73badb 
#207 moved it elsewhere but #76 added it back to its previous place; undo that part
@dummdidumm dummdidumm mentioned this pull request Oct 4, 2024
Merged
Rich-Harris pushed a commit that referenced this pull request Oct 4, 2024
@dummdidumm
remove css which is loaded from other place (#244)
cb79b16 
#207 moved it elsewhere but #76 added it back to its previous place; undo that part
@Conduitry Conduitry mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dummdidumm @Rich-Harris @Conduitry