-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the search dialog more useful/attractive #206
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks nice! I'm not a big fan of the orange/red outline on the search box and would make the matching text much darker |
The focus ring is the same one we use for keyboard navigation elsewhere. Inputs don't distinguish between Screen.Recording.2024-10-01.at.5.12.09.PM.movI think making the excerpt text darker hurts overall, because the grouping becomes less explicit. I could try adding an icon and see if that helps |
Added icons, I think it works |
merging, we can iterate from here |
the text looks better to me now. I fine the icons to be a bit confusing and think it was fine without them |
there's arguably more we could do here, but I think this is a good starting point. It drops the confusing hierarchy in favour of grouped lists (where a 'group' is like 'Docs • Svelte' or 'Tutorial • Advanced SvelteKit') with sticky headers.
It also fixes the fonts, and makes the panel bigger on screens that can afford it.