Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the search dialog more useful/attractive #206

Merged
merged 12 commits into from
Oct 1, 2024
Merged

make the search dialog more useful/attractive #206

merged 12 commits into from
Oct 1, 2024

Conversation

Rich-Harris
Copy link
Member

there's arguably more we could do here, but I think this is a good starting point. It drops the confusing hierarchy in favour of grouped lists (where a 'group' is like 'Docs • Svelte' or 'Tutorial • Advanced SvelteKit') with sticky headers.

It also fixes the fonts, and makes the panel bigger on screens that can afford it.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 10:42pm

@Rich-Harris Rich-Harris linked an issue Oct 1, 2024 that may be closed by this pull request
@benmccann
Copy link
Member

Looks nice! I'm not a big fan of the orange/red outline on the search box and would make the matching text much darker

@Rich-Harris
Copy link
Member Author

The focus ring is the same one we use for keyboard navigation elsewhere. Inputs don't distinguish between :focus and :focus-visible IIUC, so we can't remove it without harming accessibility. I think it looks fine — it makes sense for a piece of UI that popped into the center of the screen to be very explicit about where the focus went.

Screen.Recording.2024-10-01.at.5.12.09.PM.mov

I think making the excerpt text darker hurts overall, because the grouping becomes less explicit. I could try adding an icon and see if that helps

@Rich-Harris
Copy link
Member Author

Added icons, I think it works

@Rich-Harris
Copy link
Member Author

merging, we can iterate from here

@Rich-Harris Rich-Harris merged commit 80c7017 into main Oct 1, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the gh-168 branch October 1, 2024 22:42
@benmccann
Copy link
Member

the text looks better to me now. I fine the icons to be a bit confusing and think it was fine without them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign search dialog
2 participants