Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use svelte v5 in create-svelte templates #12841

Closed
wants to merge 1 commit into from

Conversation

hyunbinseo
Copy link
Contributor

Use Svelte v5 as default in create-svelte package.

Would create-svelte be deprecated and replaced with sv?

No, the new CLI replaces "npm create svelte" and "npx svelte-add". You will still use Vite everywhere it was used before

https://twitter.com/BenjaminMcCann/status/1847780400053309761


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 19, 2024

🦋 Changeset detected

Latest commit: 1066490

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codenoid
Copy link
Contributor

yes please merge this, Cloudflare can't work with Svelte 5 because it's still using version 4 (I'm using sv to upgrade to 5)

@benmccann
Copy link
Member

Yes, please use npx sv instead of npm create svelte. The create-svelte project will be going away shortly. I've updated all the docs on the new site, which will be rolled out later this week, to suggest using npx sv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants