Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: atomic builds #11760

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

magnusdahlstrand
Copy link

@magnusdahlstrand magnusdahlstrand commented Jan 30, 2024

Before this PR, when building adapter-cloudflare first removes the build directory, then initiates a build.

When using workers-sdk alongside sveltekit this leads to lots of error messages when watching and rebuilding, first due to files not existing, and then due to incomplete builds. This creates lots of output of transient errors in the console confusing the development process (especially for beginners), and also hides any real issues behind a wall of non-errors.

This PR updates the build behaviour to leave the existing build in place while building to a new temporary build location. When the build finishes, the final build destination is removed and the temporary build directory is renamed to take the place of the final build destination.

This fixes all of the transient error outputs during rebuilds. I'm working on fixes to workers-sdk as well which should further smooth the integration between these two projects.

Let me know if you have any questions or feedback, I'm all ears!

Magnus


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 84443d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare Minor
@sveltejs/adapter-cloudflare-workers Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels to me like we'd want to make this change to the cloudflare-workers-adapter as well

@eltigerchino eltigerchino changed the title feat: atomic builds in adapter-cloudflare feat: atomic builds Oct 15, 2024
@eltigerchino
Copy link
Member

I've added similar changes to the cloudflare workers adapter.

"@sveltejs/adapter-cloudflare-workers": minor
---

feat: atomic builds
Copy link
Member

@eltigerchino eltigerchino Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be a patch fix instead; it prevents those transient error messages during rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants