Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward exit code of external package commands #412

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

rChaoz
Copy link
Contributor

@rChaoz rChaoz commented Jan 22, 2025

Closes #411

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: f244c74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@412
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@412

commit: f244c74

@benmccann
Copy link
Member

We should check all the commands and add it anywhere it is missing such as

@rChaoz
Copy link
Contributor Author

rChaoz commented Jan 22, 2025

@benmccann should be all good

@rChaoz rChaoz changed the title fix: forward exit code of svelte-check fix: forward exit code of external package commands Jan 22, 2025
@benmccann benmccann merged commit ea45ddb into sveltejs:main Jan 22, 2025
8 checks passed
@benmccann
Copy link
Member

Thank you!!

@github-actions github-actions bot mentioned this pull request Jan 22, 2025
@rChaoz rChaoz deleted the fix/check-exit-code branch January 22, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sv check always returns exit code 0
2 participants