Skip to content

Commit

Permalink
Typo
Browse files Browse the repository at this point in the history
  • Loading branch information
svanderburg committed Jun 24, 2018
1 parent 422ab1f commit 9284da3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Table of Contents
- [Using private Git repositories](#using-private-git-repositories)
- [Troubleshooting](#troubleshooting)
- [Deploying peer dependencies](#deploying-peer-dependencies)
- [Striping optional dependencies](#striping-optional-dependencies)
- [Stripping optional dependencies](#striping-optional-dependencies)
- [Updating the package lock file](#updating-the-package-lock-file)
- [Disabling running NPM install](#disabling-running-npm-install)
- [API documentation](#api-documentation)
Expand Down Expand Up @@ -596,8 +596,8 @@ deploy. To generate expressions that install peer dependencies, you can add the
$ node2nix --include-peer-dependencies
```

Striping optional dependencies
------------------------------
Stripping optional dependencies
-------------------------------
When NPM packages with optional dependencies are published to the NPM registry,
the optional dependencies become regular runtime dependencies. As a result,
when deploying a package with a broken optional dependency, the deployment
Expand Down
2 changes: 1 addition & 1 deletion lib/Package.js
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ Package.prototype.resolveDependenciesFromLockedDependencies = function(dependenc

if(dependency.bundled) { // Bundled dependencies should not be included
callback();
} else if(self.deploymentConfig.stripOptionalDependencies && dependency.optional) { // When striping optional dependencies feature has been enabled, remove all optional dependencies
} else if(self.deploymentConfig.stripOptionalDependencies && dependency.optional) { // When the stripping optional dependencies feature has been enabled, remove all optional dependencies
callback();
} else if(self.production && dependency.dev) { // Development dependencies should not be included in production mode
callback();
Expand Down
4 changes: 2 additions & 2 deletions nix/node-env.nix
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ let
++ stdenv.lib.optional (stdenv.isDarwin) libtool
++ buildInputs;

inherit dontStrip; # Striping may fail a build for some package deployments
inherit dontStrip; # Stripping may fail a build for some package deployments
inherit dontNpmInstall preRebuild unpackPhase buildPhase;

compositionScript = composePackage args;
Expand Down Expand Up @@ -449,7 +449,7 @@ let
++ stdenv.lib.optional (stdenv.isDarwin) libtool
++ buildInputs;

inherit dontStrip; # Striping may fail a build for some package deployments
inherit dontStrip; # Stripping may fail a build for some package deployments
inherit dontNpmInstall unpackPhase buildPhase;

includeScript = includeDependencies { inherit dependencies; };
Expand Down

0 comments on commit 9284da3

Please sign in to comment.