Test: Fix Strict Comparison of Int to Float

See: https://mantis.ilias.de/view.php?id=39823
surlabs · Jan 10, 2024 · cece0d9 · cece0d9
1 parent b33d3ba
commit cece0d9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Modules/Test/classes/class.ilObjTest.php b/Modules/Test/classes/class.ilObjTest.php
@@ -8134,15 +8134,15 @@ public static function _getBestPass($active_id)
         );
         if ($result->numRows()) {
             $bestrow = null;
-            $bestfactor = 0;
+            $bestfactor = 0.0;
             while ($row = $ilDB->fetchAssoc($result)) {
                 if ($row["maxpoints"] > 0) {
-                    $factor = $row["points"] / $row["maxpoints"];
+                    $factor = (float) ($row["points"] / $row["maxpoints"]);
                 } else {
-                    $factor = 0;
+                    $factor = 0.0;
                 }
 
-                if ($factor === 0 && $bestfactor === 0
+                if ($factor === 0.0 && $bestfactor === 0.0
                     || $factor > $bestfactor) {
                     $bestrow = $row;
                     $bestfactor = $factor;