Test: Fix Enter in Question-Form for Non Edit Cmds

See: https://mantis.ilias.de/view.php?id=39808#c103770
surlabs · Apr 16, 2024 · b16cacd · b16cacd
1 parent ee9c2af
commit b16cacd
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/Modules/TestQuestionPool/classes/class.assFormulaQuestionGUI.php b/Modules/TestQuestionPool/classes/class.assFormulaQuestionGUI.php
@@ -54,6 +54,7 @@ protected function setQuestionSpecificTabs(ilTabsGUI $ilTabs): void
     protected function callSpecialQuestionCommands(string $cmd): void
     {
         if (preg_match('/suggestrange_(\$r\d+)/', $cmd, $matches)) {
+            $this->addSaveOnEnterOnLoadCode();
             $this->suggestRange($matches[1]);
         }
     }
@@ -738,6 +739,7 @@ private function canUseAdvancedRating($result): bool
     public function parseQuestion(): void
     {
         $this->writePostData();
+        $this->addSaveOnEnterOnLoadCode();
         $this->editQuestion();
     }
 

diff --git a/Modules/TestQuestionPool/classes/class.assQuestionGUI.php b/Modules/TestQuestionPool/classes/class.assQuestionGUI.php
@@ -234,20 +234,11 @@ public function executeCommand()
                     case 'addGIT':
                         $this->$cmd();
                         break;
+                    case 'save':
+                    case 'saveReturn':
                     case 'editQuestion':
-                        $this->tpl->addOnloadCode("
-                            let form = document.querySelector('#ilContentContainer form');
-                            let button = form.querySelector('input[name=\"cmd[save]\"]');
-                            if (form && button) {
-                                form.addEventListener('keydown', function (e) {
-                                    if (e.key === 'Enter' && e.target.type !== 'textarea') {
-                                        e.preventDefault();
-                                        form.requestSubmit(button);
-                                    }
-                                })
-                            }
-                        ");
-                        $this->editQuestion();
+                        $this->addSaveOnEnterOnLoadCode();
+                        $this->$cmd();
                         break;
                     default:
                         if (method_exists($this, $cmd)) {
@@ -2046,4 +2037,19 @@ public function setInLearningModuleContext(bool $flag): void
         $this->parent_type_is_lm = $flag;
     }
 
+    protected function addSaveOnEnterOnLoadCode(): void
+    {
+        $this->tpl->addOnloadCode("
+            let form = document.querySelector('#ilContentContainer form');
+            let button = form.querySelector('input[name=\"cmd[save]\"]');
+            if (form && button) {
+                form.addEventListener('keydown', function (e) {
+                    if (e.key === 'Enter' && e.target.type !== 'textarea') {
+                        e.preventDefault();
+                        form.requestSubmit(button);
+                    }
+                })
+            }
+        ");
+    }
 }