Merge pull request ILIAS-eLearning#7073 from utesche/scorm_favicon

bugfix 40577: SCORM player ignores favicon.ico from custom style
surlabs · Feb 20, 2024 · a543e43 · a543e43
2 parents 9950d97 + 219636a
commit a543e43
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php b/Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php
@@ -462,6 +462,7 @@ public function getPlayer(): void
             $this->tpl->setVariable($key, $value);
         }
         $this->tpl->setVariable('DOC_TITLE', 'ILIAS: ' . $this->slm->getTitle());
+	$this->tpl->setVariable("LOCATION_FAVICON", ilUtil::getImagePath("favicon.ico", ""));
         $this->tpl->setVariable("LOCATION_STYLESHEET", ilUtil::getStyleSheetLocation());
         $this->tpl->setVariable('INIT_CP_DATA', json_encode(json_decode($this->getCPDataInit())));
         $this->tpl->setVariable('INIT_CMI_DATA', json_encode($this->getCMIData($this->userId, $this->packageId)));

diff --git a/Modules/Scorm2004/templates/default/tpl.scorm2004.player.html b/Modules/Scorm2004/templates/default/tpl.scorm2004.player.html
@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" id="scormplayer">
 	<head>
 		<title>{DOC_TITLE}</title>
-		<link rel="icon" href="./templates/default/images/favicon.ico" type="image/x-icon" />
+		<link rel="icon" href="{LOCATION_FAVICON}" type="image/x-icon" />
 		<meta name="viewport" content="user-scalable=yes, initial-scale=1.0, width=device-width">
 		<meta name="apple-mobile-web-app-capable" content="yes">
 
@@ -85,4 +85,4 @@
 		</script>
 
 	</body>
-</html>
+</html>
diff --git a/templates/default/images/scorm/browsed.svg b/templates/default/images/scorm/browsed.svg