Change refactor to make run method of ASignal private

supyrb · Mar 10, 2020 · 30d0949 · 30d0949
1 parent b63c788
commit 30d0949
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/Scripts/Runtime/ASignal.cs b/Scripts/Runtime/ASignal.cs
@@ -92,13 +92,15 @@ public void Consume()
 			state = State.Consumed;
 		}
 
-		protected void CleanupForDispatch()
+		protected void StartDispatch()
 		{
 			currentIndex = 0;
 			state = State.Running;
+
+			Run();
 		}
 
-		protected void Run()
+		private void Run()
 		{
 			while (true)
 			{

diff --git a/Scripts/Runtime/Signal.cs b/Scripts/Runtime/Signal.cs
@@ -86,9 +86,8 @@ public void Dispatch()
 		{
 			BeginSignalProfilerSample("Dispatch Signal");
 
-			CleanupForDispatch();
-			Run();
-
+			StartDispatch();
+
 			EndSignalProfilerSample();
 		}
 
@@ -173,10 +172,9 @@ public void Dispatch(T context0)
 		{
 			BeginSignalProfilerSample("Dispatch Signal");
 
-			CleanupForDispatch();
 			this.context0 = context0;
-			Run();
-			
+			StartDispatch();
+
 			EndSignalProfilerSample();
 		}
 
@@ -268,11 +266,10 @@ public void Dispatch(T context0, U context1)
 		{
 			BeginSignalProfilerSample("Dispatch Signal");
 
-			CleanupForDispatch();
 			this.context0 = context0;
 			this.context1 = context1;
-			Run();
-			
+			StartDispatch();
+
 			EndSignalProfilerSample();
 		}
 
@@ -366,12 +363,11 @@ public void Dispatch(T context0, U context1, V context2)
 		{
 			BeginSignalProfilerSample("Dispatch Signal");
 
-			CleanupForDispatch();
 			this.context0 = context0;
 			this.context1 = context1;
 			this.context2 = context2;
-			Run();
-			
+			StartDispatch();
+
 			EndSignalProfilerSample();
 		}