-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2.0 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ignore system bar
Add screenshot testing support & workflow
…gates with callbacks and safari with browser
Deprecate ViewController methods in favor of Android names and accessors
Add idiomatic DSL for prettier configuration
…dd teardown support to JS evaluators to use with tests
Optimise memory and threading
…r acquires real configuration on setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.2.0
Changes in this pull request
Enhancements
This allows you to configure the SDK in a more idiomatic way:
Deprecations
This release includes multiple deprecations that will be removed in upcoming versions.
Most are internal and will not affect the public API, those that will are marked as such and a simple migration
path is provided. The notable ones in the public API are as follows:
Deprecated
DebugViewControllerActivity
in favor ofDebugViewActivity
Deprecated
PaywallViewController
in favor ofPaywallView
viewWillAppear
in favor ofbeforeViewCreated
viewDidAppear
in favor ofonViewCreated
viewWillDisappear
in favor ofbeforeOnDestroy
viewDidDisappear
in favor ofdestroyed
presentAlert
in favor ofshowAlert
Deprecated
PaywallViewControllerDelegate
in favor ofPaywallViewCallback
didFinish
in favor ofonFinished
Deprecated
PaywallViewControllerEventDelegate
in favor ofPaywallViewEventCallback
PaywallWebEvent.OpenedUrlInSafari
in favor ofPaywallWebEvent.OpenedUrlInChrome
didFinish
in favor ofonFinished
In
Superwall
, the following methods were deprecated:Superwall.paywallViewController
in favor ofSuperwall.paywallView
Superwall.eventDidOccur
argumentpaywallViewController
in favor ofpaywallView
Superwall.dismiss
in favor of `Superwall.presentPaywallViewSuperwall.presentPaywallViewController
in favor ofSuperwall.presentPaywallView
Deprecated
Paywallmanager.getPaywallViewController
in favor ofPaywallManager.getPaywallView
Deprecated
DebugManager.viewController
in favor ofDebugManager.view
Deprecated
DebugViewController
in favor ofDebugView
Deprecated
LogScope.debugViewController
in favor ofLogScope.debugView
Deprecated
PaywallPresentationRequestStatus.NoPaywallViewController
in favor ofNoPaywallView
Checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.ktlint
in the main directory and fixed any issues.