Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update soccer_world.cpp #5294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update soccer_world.cpp #5294

wants to merge 3 commits into from

Conversation

Ban1p7
Copy link

@Ban1p7 Ban1p7 commented Feb 1, 2025

Remove squash and invulnerability stars after goal
Issue #5108

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

remove squash and invulnerability starts after goal
@Alayan-stk-2
Copy link
Collaborator

Thank you for the PR!

However:

  • it would be better to do a deeper reset with a call to a dedicated kart function. For example, attachments (bombs, swatters...) also currently persist and should arguably not.
  • This won't be merged before 1.5 is out.

Moved everything into a separate kart function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants