WebXR: check for null render target (#15)

[idrisshah]

Related issue: #15

Description

Aframes does not render WebXR on Magic Leap browser. Magic Leap browser use WebXR layers but does not use OCULUS_multiview extension. As a result there is null check crash, when rendering an Aframes written WebXR content. Proposing a simple fix to resolve this issue.

This contribution is funded by Magic Leap

[idrisshah]

@dmarcos Can you please review this pull request? This is a missing check in OCULUS_multiview extension usage patch. It breaks WebXR for Magic Leap browser.

[dmarcos]

@idrisshah Thanks so much. Has this been submitted to three repo? We might just need to rebase our fork?

[idrisshah]

No, as i can see, the patch that causes WebXR to break was only merged to supermedium threejs. 2988e59. threejs repo does not have that patch.

[dmarcos]

Thanks so much!

[github-actions]

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev	Filesize PR	Diff
664.5 kB (164.8 kB)	664.5 kB (164.8 kB)	+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev	Filesize PR	Diff
456.9 kB (110.7 kB)	456.9 kB (110.7 kB)	+0 B

[idrisshah]

@dmarcos Can you tell when this change will be in production? None of the webxr AFrame samples works without this change. Thanks

[dmarcos]

It will ship on next major version (1.6.0). I bumped super-three on A-Frame repo and you can now at least use master builds that include the fix. You can find the build URLs in the commit messages if you want to try:

https://github.com/aframevr/aframe/commits/master/