chore: audit for responses. remove unused mgmt apis

apps/api/middleware/openapi.ts

@@ -1,3 +1,4 @@
+import { logger } from '@supaglue/core/lib';
 import type { NextFunction, Request, Response } from 'express';
 import * as OpenApiValidator from 'express-openapi-validator';
 import fs from 'fs';
@@ -39,6 +40,17 @@ export const openapiMiddleware = (specDir: string, version = 'v2') => {
     validateRequests: {
       removeAdditional: true,
     },
+    validateResponses: {
+      onError: (error, body, req) => {
+        logger.error(
+          {
+            error,
+            originalUrl: req.originalUrl,
+          },
+          'API response validation error'
+        );
+      },
+    },
   });
 };
 

apps/api/routes/mgmt/v2/customer/connection/index.ts

@@ -107,12 +107,7 @@ export default function init(app: Router): void {
         req.supaglueApplication.id
       );
 
-      // enrich with user_id, if we can.
-      // TODO remove this after users migrate to /_provider_user_id above
-      const [client] = await remoteService.getCrmRemoteClient(req.params.connection_id);
-      const { userId } = await client.getUserIdAndDetails();
-
-      return res.status(200).send(snakecaseKeys({ ...connection, userId }));
+      return res.status(200).send(snakecaseKeys(connection));
     }
   );
 

apps/api/routes/mgmt/v2/entity/index.ts

@@ -23,6 +23,9 @@ import { Router } from 'express';
 
 const { entityService } = getDependencyContainer();
 
+/**
+ * @deprecated
+ */
 export default function init(app: Router): void {
   const entityRouter = Router({ mergeParams: true });
 

apps/api/routes/mgmt/v2/index.ts

@@ -4,12 +4,10 @@ import { pinoAndSentryContextMiddleware } from '@/middleware/pino_context';
 import { Router } from 'express';
 import connectionSyncConfig from './connection_sync_config';
 import customer from './customer';
-import destination from './destination';
 import entity from './entity';
 import entityMapping from './entity_mapping';
 import fieldMapping from './field_mapping';
 import magicLink from './magic_link';
-import provider from './provider';
 import schema from './schema';
 import sync from './sync';
 import syncConfig from './sync_config';
@@ -23,8 +21,6 @@ export default function init(app: Router): void {
   v2Router.use(pinoAndSentryContextMiddleware);
 
   customer(v2Router);
-  destination(v2Router);
-  provider(v2Router);
   schema(v2Router);
   syncConfig(v2Router);
   sync(v2Router);