chore: audit for responses. remove unused mgmt apis

apps/api/middleware/openapi.ts

@@ -1,3 +1,4 @@
+import { logger } from '@/../../packages/core/lib/logger';
 import type { NextFunction, Request, Response } from 'express';
 import * as OpenApiValidator from 'express-openapi-validator';
 import fs from 'fs';
@@ -39,6 +40,17 @@ export const openapiMiddleware = (specDir: string, version = 'v2') => {
     validateRequests: {
       removeAdditional: true,
     },
+    validateResponses: {
+      onError: (error, body, req) => {
+        logger.error(
+          {
+            error,
+            originalUrl: req.originalUrl,
+          },
+          'API reference validation error'
+        );
+      },
+    },
   });
 };
 

apps/api/routes/mgmt/v2/customer/connection/index.ts

@@ -107,11 +107,6 @@ export default function init(app: Router): void {
         req.supaglueApplication.id
       );
 
-      // enrich with user_id, if we can.
-      // TODO remove this after users migrate to /_provider_user_id above
-      const [client] = await remoteService.getCrmRemoteClient(req.params.connection_id);
-      const { userId } = await client.getUserIdAndDetails();
-
       return res.status(200).send(snakecaseKeys({ ...connection, userId }));
     }
   );

apps/api/routes/mgmt/v2/entity/index.ts

@@ -23,6 +23,9 @@ import { Router } from 'express';
 
 const { entityService } = getDependencyContainer();
 
+/**
+ * @deprecated
+ */
 export default function init(app: Router): void {
   const entityRouter = Router({ mergeParams: true });
 

apps/api/routes/mgmt/v2/index.ts

@@ -4,12 +4,10 @@ import { pinoAndSentryContextMiddleware } from '@/middleware/pino_context';
 import { Router } from 'express';
 import connectionSyncConfig from './connection_sync_config';
 import customer from './customer';
-import destination from './destination';
 import entity from './entity';
 import entityMapping from './entity_mapping';
 import fieldMapping from './field_mapping';
 import magicLink from './magic_link';
-import provider from './provider';
 import schema from './schema';
 import sync from './sync';
 import syncConfig from './sync_config';
@@ -23,8 +21,6 @@ export default function init(app: Router): void {
   v2Router.use(pinoAndSentryContextMiddleware);
 
   customer(v2Router);
-  destination(v2Router);
-  provider(v2Router);
   schema(v2Router);
   syncConfig(v2Router);
   sync(v2Router);

apps/api/routes/mgmt/v2/sync_config/index.ts

@@ -1,23 +1,9 @@
 import { getDependencyContainer } from '@/dependency_container';
 import type {
-  CreateSyncConfigPathParams,
-  CreateSyncConfigRequest,
-  CreateSyncConfigResponse,
-  DeleteSyncConfigPathParams,
-  DeleteSyncConfigRequest,
-  DeleteSyncConfigResponse,
-  GetSyncConfigPathParams,
-  GetSyncConfigRequest,
-  GetSyncConfigResponse,
   GetSyncConfigsPathParams,
   GetSyncConfigsRequest,
   GetSyncConfigsResponse,
-  UpdateSyncConfigPathParams,
-  UpdateSyncConfigRequest,
-  UpdateSyncConfigResponse,
 } from '@supaglue/schemas/v2/mgmt';
-import type { CommonObjectType } from '@supaglue/types';
-import { camelcaseKeys } from '@supaglue/utils/camelcase';
 import { snakecaseKeys } from '@supaglue/utils/snakecase';
 import type { Request, Response } from 'express';
 import { Router } from 'express';
@@ -38,75 +24,5 @@ export default function init(app: Router): void {
     }
   );
 
-  syncConfigRouter.post(
-    '/',
-    async (
-      req: Request<CreateSyncConfigPathParams, CreateSyncConfigResponse, CreateSyncConfigRequest>,
-      res: Response<CreateSyncConfigResponse>
-    ) => {
-      const syncConfig = await syncConfigService.create({
-        applicationId: req.supaglueApplication.id,
-        ...camelcaseKeys({
-          ...req.body,
-          config: {
-            ...req.body.config,
-            common_objects: req.body.config.common_objects?.map((commonObject) => ({
-              ...commonObject,
-              object: commonObject.object as CommonObjectType,
-            })),
-          },
-        }),
-      });
-      return res.status(201).send(snakecaseKeys(syncConfig));
-    }
-  );
-
-  syncConfigRouter.get(
-    '/:sync_config_id',
-    async (
-      req: Request<GetSyncConfigPathParams, GetSyncConfigResponse, GetSyncConfigRequest>,
-      res: Response<GetSyncConfigResponse>
-    ) => {
-      const syncConfig = await syncConfigService.getByIdAndApplicationId(
-        req.params.sync_config_id,
-        req.supaglueApplication.id
-      );
-      return res.status(200).send(snakecaseKeys(syncConfig));
-    }
-  );
-
-  syncConfigRouter.put(
-    '/:sync_config_id',
-    async (
-      req: Request<UpdateSyncConfigPathParams, UpdateSyncConfigResponse, UpdateSyncConfigRequest>,
-      res: Response<UpdateSyncConfigResponse>
-    ) => {
-      const syncConfig = await syncConfigService.update(req.params.sync_config_id, req.supaglueApplication.id, {
-        ...camelcaseKeys({
-          ...req.body,
-          config: {
-            ...req.body.config,
-            common_objects: req.body.config.common_objects?.map((commonObject) => ({
-              ...commonObject,
-              object: commonObject.object as CommonObjectType,
-            })),
-          },
-        }),
-      });
-      return res.status(200).send(snakecaseKeys(syncConfig));
-    }
-  );
-
-  syncConfigRouter.delete(
-    '/:sync_config_id',
-    async (
-      req: Request<DeleteSyncConfigPathParams, DeleteSyncConfigResponse, DeleteSyncConfigRequest>,
-      res: Response<DeleteSyncConfigResponse>
-    ) => {
-      await syncConfigService.delete(req.params.sync_config_id, req.supaglueApplication.id);
-      return res.status(204).end();
-    }
-  );
-
   app.use('/sync_configs', syncConfigRouter);
 }