Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sam/plv8 version update #1226

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Sam/plv8 version update #1226

merged 3 commits into from
Sep 24, 2024

Conversation

samrose
Copy link
Contributor

@samrose samrose commented Sep 23, 2024

What kind of change does this PR introduce?

This PR updates plv8 to 3.1.10 which is the last version of the project that still builds plcoffee, plls, plv8 and also is has support for pg16 (although this still needs to be tested and we may need to make contributions to plv8 or patches on our end to round out support after testing)

Notes: we need to move to plv8 3.2.x to support using v8 sourced from nodejs 20_x will be in a future PR.

This PR has been tested on aarch64-darwin x86_64-linux aarch-64-linux

@samrose samrose requested a review from olirice September 23, 2024 14:45
@samrose samrose self-assigned this Sep 23, 2024
@samrose samrose requested a review from a team as a code owner September 23, 2024 14:45
Copy link
Contributor

@darora darora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcnc do we need any changes to upgrades to account for a plv8 version update? Or will users automatically be prompted to drop their plv8 objects anyway

@samrose samrose merged commit 9b5146e into develop Sep 24, 2024
8 checks passed
@samrose samrose deleted the sam/plv8-version-update branch September 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants