All exceptions inherit RuntimeException

sunrise-php · Nov 18, 2018 · 2ef840f · 2ef840f
1 parent aa052ae
commit 2ef840f
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 31 deletions.
diff --git a/src/Exception/Exception.php b/src/Exception/Exception.php
diff --git a/src/Exception/UnableToCreateTransliteratorException.php b/src/Exception/UnableToCreateTransliteratorException.php
@@ -11,8 +11,13 @@
 
 namespace Sunrise\Slugger\Exception;
 
+/**
+ * Import classes
+ */
+use RuntimeException;
+
 /**
  * UnableToCreateTransliteratorException
  */
-class UnableToCreateTransliteratorException extends Exception
+class UnableToCreateTransliteratorException extends RuntimeException
 {}
diff --git a/src/Exception/UnableToTransliterateException.php b/src/Exception/UnableToTransliterateException.php
@@ -11,8 +11,13 @@
 
 namespace Sunrise\Slugger\Exception;
 
+/**
+ * Import classes
+ */
+use RuntimeException;
+
 /**
  * UnableToTransliterateException
  */
-class UnableToTransliterateException extends Exception
+class UnableToTransliterateException extends RuntimeException
 {}
diff --git a/src/Exception/UnsupportedTransliteratorIdentifierException.php b/src/Exception/UnsupportedTransliteratorIdentifierException.php
@@ -11,8 +11,13 @@
 
 namespace Sunrise\Slugger\Exception;
 
+/**
+ * Import classes
+ */
+use RuntimeException;
+
 /**
  * UnsupportedTransliteratorIdentifierException
  */
-class UnsupportedTransliteratorIdentifierException extends Exception
+class UnsupportedTransliteratorIdentifierException extends RuntimeException
 {}
diff --git a/tests/SluggerTest.php b/tests/SluggerTest.php
@@ -3,7 +3,6 @@
 namespace Sunrise\Slugger\Tests;
 
 use PHPUnit\Framework\TestCase;
-use Sunrise\Slugger\Exception\Exception;
 use Sunrise\Slugger\Exception\UnableToCreateTransliteratorException;
 use Sunrise\Slugger\Exception\UnableToTransliterateException;
 use Sunrise\Slugger\Exception\UnsupportedTransliteratorIdentifierException;
@@ -137,9 +136,8 @@ public function testTransliterateWithInvalidCompound()
 
 	public function testExceptions()
 	{
-		$this->assertInstanceOf(\RuntimeException::class, new Exception(''));
-		$this->assertInstanceOf(Exception::class, new UnableToCreateTransliteratorException(''));
-		$this->assertInstanceOf(Exception::class, new UnableToTransliterateException(''));
-		$this->assertInstanceOf(Exception::class, new UnsupportedTransliteratorIdentifierException(''));
+		$this->assertInstanceOf(\RuntimeException::class, new UnableToCreateTransliteratorException(''));
+		$this->assertInstanceOf(\RuntimeException::class, new UnableToTransliterateException(''));
+		$this->assertInstanceOf(\RuntimeException::class, new UnsupportedTransliteratorIdentifierException(''));
 	}
 }