Skip to content

Commit

Permalink
Replace NDMeta.remove with __delitem__.
Browse files Browse the repository at this point in the history
  • Loading branch information
DanRyanIrish committed Jul 2, 2024
1 parent cdc3f8f commit 2373209
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions ndcube/meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,12 @@ def add(self, name, value, comment=None, axis=None, overwrite=False):
# This must be done after updating self._axes otherwise it may error.
self.__setitem__(name, value)

def remove(self, name):
def __delitem__(self, name):
if name in self._comments:
del self._comments[name]
if name in self._axes:
del self._axes[name]
del self[name]
super().__delitem__(name)

def __setitem__(self, key, val):
axis = self.axes.get(key, None)
Expand Down Expand Up @@ -425,7 +425,7 @@ def __getitem__(self, item):
new_value = new_value[0]
# Overwrite metadata value with newly sliced version.
if drop_key:
new_meta.remove(key)
del new_meta[key]
else:
new_meta.add(key, new_value, self.meta.comments.get(key, None), new_axis,
overwrite=True)
Expand Down
4 changes: 2 additions & 2 deletions ndcube/tests/test_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,10 @@ def test_add_overwrite_error(basic_meta):
meta.add("a", "world", None, None)


def test_remove(basic_meta):
def test_del(basic_meta):
meta = basic_meta
name = "b"
meta.remove(name)
del meta[name]
assert name not in meta.keys()
assert name not in meta.comments.keys()
assert name not in meta.axes.keys()
Expand Down

0 comments on commit 2373209

Please sign in to comment.