Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough classes in lib for using github api, spec file for testing, add… #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sunny-moore
Copy link
Owner

…ed footer to application.html.erb to hold the api statistics

@alepbloyd
Copy link
Collaborator

@sunny-moore I pulled this down after the merge conflicts, and I'm running into issues with running 'bundle install' or 'bundle update' and it's not finding gems, so I can't seem to get anything to run. Did you run into this at all when you were working on this? If not, it might be something with the merge conflicts to work out.

@alepbloyd
Copy link
Collaborator

I'm looking back at this and realizing I didn't run 'gem install httparty' etc etc oops, so the bundling stuff all seems good. Everything is failing, but I'm realizing that that is probably a result of running out of API calls, so I think probably all good?

@tig-o or @sage-skaff - Can one of y'all review this one too, since my review process was uh not great here.

@sunny-moore
Copy link
Owner Author

@alepbloyd Yes, I included the httparty and json gems at the very top of the gemfile (they didn't work in the development, test area)

@alepbloyd
Copy link
Collaborator

@sunny-moore When I pull and run it, I get these errors when I open it in browser and when I run tests

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants