Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
Signed-off-by: sunby <[email protected]>
  • Loading branch information
sunby committed Feb 20, 2025
1 parent e6bccd8 commit fccf4a4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ INSTALL_PATH := $(PWD)/bin
LIBRARY_PATH := $(PWD)/lib
PGO_PATH := $(PWD)/configs/pgo
OS := $(shell uname -s)
mode = Release
mode = Debug

use_disk_index = OFF
ifdef disk_index
Expand Down
9 changes: 8 additions & 1 deletion internal/core/unittest/test_chunk_cache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,14 @@ TEST_P(ChunkCacheTest, Read) {
actual_sparse_row.data()));
expected_sparse_size += bytes;
}
Assert(sparse_column->DataByteSize() == expected_sparse_size);

expected_sparse_size += (N + 7) / 8;
expected_sparse_size += sizeof(int64_t) * (N + 1);
auto actual_sparse_size = sparse_column->DataByteSize();
std::cout << "actual_sparse_size: " << actual_sparse_size
<< ", expected_sparse_size: " << expected_sparse_size
<< std::endl;
Assert(actual_sparse_size == expected_sparse_size);

cc->Remove(dense_file_name);
cc->Remove(sparse_file_name);
Expand Down
8 changes: 4 additions & 4 deletions internal/querynodev2/segments/segment.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,10 +342,10 @@ func NewSegment(ctx context.Context,
if _, err := GetDynamicPool().Submit(func() (any, error) {
var err error
csegment, err = segcore.CreateCSegment(&segcore.CreateCSegmentRequest{
Collection: collection.ccollection,
SegmentID: loadInfo.GetSegmentID(),
SegmentType: segmentType,
IsSorted: loadInfo.GetIsSorted(),
Collection: collection.ccollection,
SegmentID: loadInfo.GetSegmentID(),
SegmentType: segmentType,
IsSorted: loadInfo.GetIsSorted(),
})
return nil, err
}).Await(); err != nil {
Expand Down

0 comments on commit fccf4a4

Please sign in to comment.