Update binlog event format (milvus-io#18347)

Signed-off-by: xige-16 <[email protected]> Signed-off-by: xige-16 <[email protected]>
sunby · Aug 11, 2022 · e40061b · e40061b
1 parent 6c3dbf0
commit e40061b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/developer_guides/chap08_binlog.md b/docs/developer_guides/chap08_binlog.md
@@ -54,11 +54,11 @@ Binlog file consists of 4 bytes magic number and a series of events. The first e
 |        +----------------------------+---------------------------------------------------------------------+
 |        | PayloadDataType  65 : 4    | data type of payload                                                |
 |        +----------------------------+---------------------------------------------------------------------+
+|        | PostHeaderLengths n : n    | header lengths for all event types                                  |
+|        +----------------------------+---------------------------------------------------------------------+
 |        | ExtraLength      69 : 4    | length of extra information                                         |
 |        +----------------------------+---------------------------------------------------------------------+
 |        | ExtraBytes       73 : n    | extra information in json format                                    |
-|        +----------------------------+---------------------------------------------------------------------+
-|        | PostHeaderLengths n : n    | header lengths for all event types                                  |
 +=====================================+=====================================================================|
 ```
 

diff --git a/internal/storage/data_codec.go b/internal/storage/data_codec.go
@@ -286,6 +286,7 @@ func (insertCodec *InsertCodec) Serialize(partitionID UniqueID, segmentID Unique
 	startTs := ts[0]
 	endTs := ts[len(ts)-1]
 
+	// sort insert data by rowID
 	dataSorter := &DataSorter{
 		InsertCodec: insertCodec,
 		InsertData:  data,