Fix rootcoord goroutine leak (milvus-io#16071)

issue: milvus-io#15658 Signed-off-by: sunby <[email protected]> Co-authored-by: sunby <[email protected]>
sunby · Mar 16, 2022 · 256ccb8 · 256ccb8
1 parent 2047209
commit 256ccb8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/internal/mq/msgstream/mq_msgstream.go b/internal/mq/msgstream/mq_msgstream.go
@@ -186,9 +186,6 @@ func (ms *mqMsgStream) Start() {
 }
 
 func (ms *mqMsgStream) Close() {
-	if !atomic.CompareAndSwapInt32(&ms.closed, 0, 1) {
-		return
-	}
 	ms.streamCancel()
 	ms.wait.Wait()
 
@@ -204,6 +201,10 @@ func (ms *mqMsgStream) Close() {
 	}
 
 	ms.client.Close()
+
+	if !atomic.CompareAndSwapInt32(&ms.closed, 0, 1) {
+		return
+	}
 	close(ms.receiveBuf)
 }