forked from Sunbird-Lern/userorg-service
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KB-2925 | New API for the OTP generation for email/phone verification #62
Merged
karthik-tarento
merged 6 commits into
sunbird-cb:4.8.12-dev
from
tarentomaheshvakkund:4.8.12-otpv3enhancements
Mar 6, 2024
Merged
KB-2925 | New API for the OTP generation for email/phone verification #62
karthik-tarento
merged 6 commits into
sunbird-cb:4.8.12-dev
from
tarentomaheshvakkund:4.8.12-otpv3enhancements
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarentomaheshvakkund
commented
Mar 5, 2024
- OTP access token enhancements
1. OTP access token enhancements
1. Secret Key added to external resource properties file.
1. Secret key removed
1. Otp timeout is configured to 5mins.
karthik-tarento
suggested changes
Mar 6, 2024
1. Added the column names to the casssandraTablecolumn.properties.
1. Removed the comment line.
|
karthik-tarento
added a commit
that referenced
this pull request
Mar 21, 2024
* KB-2925 | New API for the OTP generation for email/phone verification (#61) * KB-2925 | New API for the OTP generation for email/phone verification 1. Added a new route for the OTP generation API. 2. Added a new controller generateOTPv3 for handling the new API requests. 3. Added new method validateGenerateOtpRequestV3 for validation of the json fields. 4. Added a new method generateOTPV3 in the actor class to process the request. * KB-2925 | New API for the OTP generation for email/phone verification 1. Replicated the existing generate OTP API and integrated two new fields in the Request body i.e contextType and contextAttributes. * KB-2925 | New API for the OTP generation for email/phone verification 1. 1. Replicated the existing verify OTP API and integrated access token field to be updated. * KB-2925 - New API for the OTP generation for email/phone verification Code enhancements. * KB-2925 - New API for the OTP generation for email/phone verification 1. Code Review Changes. * KB-2925 | New API for the OTP generation for email/phone verification (#62) * KB-2925 | New API for the OTP generation for email/phone verification 1. OTP access token enhancements * KB-2925 | New API for the OTP generation for email/phone verification 1. Secret Key added to external resource properties file. * KB-2925 | New API for the OTP generation for email/phone verification 1. Secret key removed * KB-2925 | New API for the OTP generation for email/phone verification 1. Otp timeout is configured to 5mins. * KB-2925 | New API for the OTP generation for email/phone verification 1. Added the column names to the casssandraTablecolumn.properties. * KB-2925 | New API for the OTP generation for email/phone verification 1. Removed the comment line. --------- Co-authored-by: tarentomaheshvakkund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.