Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skeleton to Symfony 7.2 #266

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Update Skeleton to Symfony 7.2 #266

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a22dd2f
Update to Symfony 7.2
alexander-schranz Dec 9, 2024
a538714
Update framework bundle
alexander-schranz Dec 9, 2024
115604d
Fix recipes update conflicts
alexander-schranz Jan 9, 2025
35bb9e3
Update recipes
alexander-schranz Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed .env.dev
View file
Open in desktop
Empty file.
30 changes: 15 additions & 15 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,16 @@
"scheb/2fa-trusted-device": "^7.2",
"stof/doctrine-extensions-bundle": "^1.11",
"sulu/sulu": "~2.6.6",
"symfony/config": "^7.1",
"symfony/dotenv": "^7.1",
"symfony/config": "^7.2",
"symfony/dotenv": "^7.2",
"symfony/flex": "^1.17 || ^2.0",
"symfony/framework-bundle": "^7.1",
"symfony/mailer": "^7.1",
"symfony/monolog-bridge": "^7.1",
"symfony/framework-bundle": "^7.2",
"symfony/mailer": "^7.2",
"symfony/monolog-bridge": "^7.2",
"symfony/monolog-bundle": "^3.4",
"symfony/runtime": "^7.1",
"symfony/security-bundle": "^7.1",
"symfony/twig-bundle": "^7.1"
"symfony/runtime": "^7.2",
"symfony/security-bundle": "^7.2",
"symfony/twig-bundle": "^7.2"
},
"require-dev": {
"jangregor/phpstan-prophecy": "^1.0",
Expand All @@ -66,13 +66,13 @@
"phpunit/phpunit": "^9.6",
"rector/rector": "^1.0",
"sulu/sulu-rector": "^1.0",
"symfony/browser-kit": "^7.1",
"symfony/css-selector": "^7.1",
"symfony/debug-bundle": "^7.1",
"symfony/error-handler": "^7.1",
"symfony/phpunit-bridge": "^7.1",
"symfony/browser-kit": "^7.2",
"symfony/css-selector": "^7.2",
"symfony/debug-bundle": "^7.2",
"symfony/error-handler": "^7.2",
"symfony/phpunit-bridge": "^7.2",
"symfony/thanks": "^1.2",
"symfony/web-profiler-bundle": "^7.1",
"symfony/web-profiler-bundle": "^7.2",
"thecodingmachine/phpstan-strict-rules": "^1.0",
"vincentlanglet/twig-cs-fixer": "^3.0"
},
Expand Down Expand Up @@ -203,7 +203,7 @@
"extra": {
"symfony": {
"allow-contrib": true,
"require": "7.1.*"
"require": "7.2.*"
}
}
}
11 changes: 11 additions & 0 deletions config/packages/csrf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Enable stateless CSRF protection for forms and logins/logouts
framework:
form:
# csrf_protection:
# token_id: submit
#
# csrf_protection:
# stateless_token_ids:
# - submit
# - authenticate
# - logout
Comment on lines +4 to +11
Copy link
Member Author

@alexander-schranz alexander-schranz Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is enabled by default in Symfony Skeleton. Not sure if we should enable it or not.

We need to test sulu/form-bundle before enabling it. Also updates its csrf protection documentation. So I will current case keep it outcommented.

3 changes: 1 addition & 2 deletions config/packages/framework.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# see https://symfony.com/doc/current/reference/configuration/framework.html
framework:
secret: '%env(APP_SECRET)%'
#csrf_protection: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was moved to own csrf.yaml file

http_method_override: true # enable also in the index.php
http_method_override: true # enabled also in the index.php

# Enables session support. Note that the session will ONLY be started if you read or write from it.
# Remove or comment this section to explicitly disable session support.
Expand Down
12 changes: 12 additions & 0 deletions symfony.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,18 @@
".env.dev"
]
},
"symfony/form": {
"version": "7.2",
"recipe": {
"repo": "github.com/symfony/recipes",
"branch": "main",
"version": "7.2",
"ref": "7d86a6723f4a623f59e2bf966b6aad2fc461d36b"
},
"files": [
"config/packages/csrf.yaml"
]
},
"symfony/framework-bundle": {
"version": "7.1",
"recipe": {
Expand Down