Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Blacklist to Registration Rule #157

Open
wants to merge 3 commits into
base: 2.0
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Tests
  • Loading branch information
Oliver Kossin committed Jul 26, 2024
commit 6da29f311ebc4fc9206183e6b6f829d0b3470f95
2 changes: 1 addition & 1 deletion Resources/translations/admin.de.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"sulu_community.blacklist": "RegistrationRule",
"sulu_community.registration_rule": "RegistrationRule",
"sulu_community.pattern": "Absender",
"sulu_community.type": "Typ",
"sulu_community.request": "Bestätigen",
2 changes: 1 addition & 1 deletion Resources/translations/admin.en.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"sulu_community.blacklist": "RegistrationRule",
"sulu_community.registration_rule": "RegistrationRule",
"sulu_community.pattern": "Sender",
"sulu_community.type": "Type",
"sulu_community.request": "Confirmation",
2 changes: 1 addition & 1 deletion Resources/translations/admin.fr.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"sulu_community.blacklist": "RegistrationRule",
"sulu_community.registration_rule": "RegistrationRule",
"sulu_community.pattern": "Expéditeur",
"sulu_community.type": "Type",
"sulu_community.request": "Confirmer",
6 changes: 3 additions & 3 deletions Tests/Functional/Controller/RegistrationTest.php
Original file line number Diff line number Diff line change
@@ -205,7 +205,7 @@ public function testRegistrationRegistrationRuleRequested(): ?RawMessage
$this->markTestSkipped('Skip test for swift mailer.');
}

$this->createBlacklistItem($this->getEntityManager(), '*@sulu.io', RegistrationRule::TYPE_REQUEST);
$this->createRegistrationRuleItem($this->getEntityManager(), '*@sulu.io', RegistrationRuleItem::TYPE_REQUEST);

$crawler = $this->client->request('GET', '/registration');
$this->assertHttpStatusCode(200, $this->client->getResponse());
@@ -241,7 +241,7 @@ public function testRegistrationRegistrationRuleRequested(): ?RawMessage

public function testRegistrationRuleConfirm(): void
{
$message = $this->testRegistrationRegistrationRuleedRequested();
$message = $this->testRegistrationRegistrationRuleRequested();

$emailCrawler = new Crawler();
$emailCrawler->addContent($message->getHtmlBody());
@@ -270,7 +270,7 @@ public function testRegistrationRuleConfirm(): void

public function testRegistrationRuleBlocked(): void
{
$message = $this->testRegistrationRegistrationRuleedRequested();
$message = $this->testRegistrationRegistrationRuleRequested();

$emailCrawler = new Crawler();
$emailCrawler->addContent($message->getHtmlBody());