Display link to item's collection's item. #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlittman
force-pushed
the
t715-collection_member
branch
from
7be3039 to
b56077f
Compare
jcoyne
requested changes
Oct 25, 2023
app/views/purl/_collection.html.erb
Outdated
| @@ -0,0 +1,15 @@ | |||
| <% if document.containing_purl_collections.any? %> | |||
There was a problem hiding this comment.
Should we just use .present? here instead of .any? We don't need to test the truthiness of any of these values, right?
app/views/purl/show.html.erb
Outdated
| @@ -6,7 +6,7 @@ | |||
| <% end %> | |||
| <%= tag :link, rel: "alternate", title: "MODS XML", type: 'application/xml', href: purl_url(@purl, format: 'mods') if @purl.mods? %> | |||
| <%= tag :link, rel: "alternate", title: "IIIF Manifest", type: 'application/json', href: iiif_manifest_url(@purl) if @purl.iiif_manifest? %> | |||
| <%= tag :link, rel: "up", href: purl_url(@purl.containing_collection) if @purl.containing_collection.present? %> | |||
| <%= tag :link, rel: "up", href: purl_url(@purl.containing_collections.first) if @purl.containing_collections.any? %> | |||
There was a problem hiding this comment.
Again, I think present? is ideal here unless we're trying to filter out falsey values.
justinlittman
force-pushed
the
t715-collection_member
branch
from
b56077f to
6fc28fa
Compare
jcoyne
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #715