Don't include version in sul-embed iframe URL when purl is base url #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewjbtw would you like to test this? |
|
Yes - is it already in stage? |
lwrubel
changed the title
|
Requires a tweak so that if the URL is a head version with a version in the URL, still include that in the embed URL. The presence or lack of a version in the URL should be the same as what's in the embed URL. |
lwrubel
changed the title
lwrubel
force-pushed
the
t1135-embed-url
branch
from
47e72a6 to
22f8133
Compare
lwrubel
changed the title
justinlittman
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1135.
Updates embed iframe URL and embed code to use base URL when head version.
Andrew tested and approved.