Skip to content

Commit

Permalink
Convert feature spec to request spec
Browse files Browse the repository at this point in the history
  • Loading branch information
jcoyne committed Aug 19, 2024
1 parent e76dee8 commit 6d9b267
Show file tree
Hide file tree
Showing 2 changed files with 106 additions and 123 deletions.
18 changes: 8 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2024-08-14 21:47:26 UTC using RuboCop version 1.65.1.
# on 2024-08-19 13:36:48 UTC using RuboCop version 1.65.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -18,7 +18,7 @@ Lint/DuplicateBranch:
Metrics/BlockLength:
Max: 58

# Offense count: 3
# Offense count: 4
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
Max: 192
Expand All @@ -40,21 +40,20 @@ Naming/HeredocDelimiterNaming:
Exclude:
- 'spec/model/purl_version_spec.rb'

# Offense count: 21
# Offense count: 19
# Configuration parameters: Prefixes, AllowedPatterns.
# Prefixes: when, with, without
RSpec/ContextWording:
Exclude:
- 'spec/features/display_purl_page_spec.rb'
- 'spec/features/iiif3_manifest_spec.rb'
- 'spec/features/iiif_manifest_spec.rb'
- 'spec/integration/purl_spec.rb'
- 'spec/views/purl/_find_it.html.erb_spec.rb'

# Offense count: 52
# Offense count: 51
# Configuration parameters: CountAsOne.
RSpec/ExampleLength:
Max: 45
Max: 48

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
Expand All @@ -79,9 +78,9 @@ RSpec/LeadingSubject:
- 'spec/model/content_metadata_spec.rb'
- 'spec/model/iiif_presentation_manifest_spec.rb'

# Offense count: 80
# Offense count: 81
RSpec/MultipleExpectations:
Max: 19
Max: 22

# Offense count: 41
# Configuration parameters: AllowSubject.
Expand Down Expand Up @@ -122,11 +121,10 @@ Rails/Blank:
Exclude:
- 'app/models/iiif_presentation_manifest.rb'

# Offense count: 5
# Offense count: 4
Rails/I18nLocaleTexts:
Exclude:
- 'app/controllers/feedback_forms_controller.rb'
- 'app/controllers/purl_controller.rb'
- 'app/controllers/webauth_controller.rb'
- 'app/mailers/feedback_mailer.rb'

Expand Down
Loading

0 comments on commit 6d9b267

Please sign in to comment.