Using standard emphasized link font weight #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudajkhan
changed the title
jcoyne
reviewed
Jan 9, 2025
|
|
||
| // Allows for emphasized link weight for 'Spotlight at Stanford' | ||
| .nav-link.emphasized { | ||
| font-weight: 500; |
There was a problem hiding this comment.
Can we just use the pre-existing fw-medium Bootstrap class for this?
jcoyne
requested changes
Jan 9, 2025
jcoyne
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2742 .
Note: The font weights for the other examples (regular links and menu links) seem to be consistent with what has been suggested so this PR focuses on emphasized links.
To conform with the font-weight requirements for emphasized links, this pull request does the following:
Before:
Social Justice tag - inactive
Social Justice tag - active
Spotlight at Stanford link
After:
Social Justice tag - inactive
Social Justice tag - active
Spotlight at Stanford link
