Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade openseadragon #2773

Closed
wants to merge 1 commit into from
Closed

Upgrade openseadragon #2773

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Dec 19, 2024

No description provided.

@jcoyne jcoyne force-pushed the osd branch 2 times, most recently from 1df20c6 to 9906e7a Compare December 19, 2024 18:53
@jcoyne jcoyne force-pushed the osd branch 3 times, most recently from 2cd8ec6 to c76b12a Compare January 6, 2025 19:53
@taylor-steve
Copy link
Contributor

I'm getting an asset error when viewing an OSD item:

Asset `openseadragon/build/openseadragon/images/zoomin_rest.png` was not declared to be precompiled in production.
Declare links to your assets in `app/assets/config/manifest.js`.

  //= link openseadragon/build/openseadragon/images/zoomin_rest.png

@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 7, 2025

@taylor-steve I linked the directory in the manifest file. Does that fix it?

@taylor-steve
Copy link
Contributor

@jcoyne yes, that fixes the asset error. Now there's a JS error:

index.js:8  Uncaught ReferenceError: OpenSeadragon is not defined
    at index.js:8:2
    at NodeList.forEach (<anonymous>)
    at NodeList.openseadragon (index.js:8:2)
    at initOpenSeadragon (index.js:8:2)
    at index.js:8:2
    at fn.___hb (index.js:8:2)

@taylor-steve
Copy link
Contributor

@jcoyne: @corylown and I were looking at this today in relation to getting dep updates done on Exhibits. I think this is very close to working, seems like it needs:

  • Updated openseadragon (I tried 1.0.15)
  • The asset path and the require for the Openseadragon (non-gem) package

@corylown
Copy link
Contributor

OSD updated via #2810

@corylown corylown closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants