Remove unnecessary call to collapse #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't this this is needed after the move to Bootstrap 5. This fixes the "Full text highlighting when a document has non-english full text stems Portuguese properly" issue.
jcoyne
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't this this is wanted after the move to Bootstrap 5. I think setting the class is sufficient. Calling collapse toggles the state to the opposite of what tests are expecting.
This fixes the
Full text highlighting when a document has non-english full text stems Portuguese properlyissue. Turns out it was a flappy test, just flappy in the worst direction...