Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gradle #64

Closed
wants to merge 1 commit into from
Closed

Remove gradle #64

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Nov 28, 2023

The bundled version is out of date. We should run with Gradle 8 instead. Install via brew install gradle

The bundled version is out of date. We should run with Gradle 8 instead.  Install via `brew install gradle`
@jcoyne jcoyne marked this pull request as draft November 28, 2023 23:00
@jmartin-sul
Copy link
Member

according to https://docs.gradle.org/8.4/userguide/gradle_wrapper.html:

The recommended way to execute any Gradle build is with the help of the Gradle Wrapper (referred to as "Wrapper").

and it goes on to list some pros about consistency of builds between different machines.

i think maybe we should close this PR? the build.gradle part was done in #65, which also upgraded to the latest gradlew scripts and configs. #69 fixes the gradle-wrapper.jar oversight from #65, as well as showing one way to fix the CI build. #66 got rid of gradle/wrapper/dists/gradle-2.13-bin.zip. so i think that covers almost everything happening in this PR. it might still be nice to have a README update about upgrading gradlew locally and checking in the changes if the project hasn't been touched in a while.

i'm also open to getting rid of gradlew if we don't think it'll be beneficial (or beneficial enough to warrant having to update it every so often and check in said updates).

@jcoyne jcoyne closed this Nov 29, 2023
@jmartin-sul jmartin-sul deleted the remove-gradle branch November 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants