Check that search_state.query_param responds to match? #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Sep 24, 2024
| @@ -28,5 +28,13 @@ | |||
| expect(solr_parameters[:mm]).to be_nil | |||
| end | |||
| end | |||
|
|
|||
| context "when the query isn't a string" do | |||
| let(:query) { { q: { a: 1 } } } | |||
There was a problem hiding this comment.
How does this query occur in the real world?
There was a problem hiding this comment.
When an item is embedded on a page in spotlight.
There was a problem hiding this comment.
Is there a page I can go to in order to see this?
There was a problem hiding this comment.
You can duplicate this locally by adding an item row widget with one or more items added to it to any custom page in DLME, such as the home page, a feature page or about page. This is blocking Jacob from creating a page in DLME.
There was a problem hiding this comment.
Merging this, but we believe this may just be cover for a deeper issue #1889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
which occurs when an item is embedded in a search context, like the exhibit home page.