Add reCAPTCHA to feedback form #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
2411-add-recaptcha
branch
2 times, most recently
from
a837bd9 to
1f707c0
Compare
taylor-steve
force-pushed
the
2411-add-recaptcha
branch
2 times, most recently
from
90d767f to
d68ae7e
Compare
taylor-steve
force-pushed
the
2411-add-recaptcha
branch
2 times, most recently
from
aaa1831 to
d3ce7e4
Compare
corylown
requested changes
Nov 19, 2024
There was a problem hiding this comment.
@taylor-steve this looks good, except the layout of the "This site is protected..." text in the feedback modal seems off:
Should it be inside the .modal-body div and maybe not have the col-sm-9 offset-sm-3 boostrap classes?
taylor-steve
force-pushed
the
2411-add-recaptcha
branch
from
d3ce7e4 to
622e8e9
Compare
|
@corylown thanks for the catch. I've updated the markup:
|
corylown
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.