Allow disabling search throttling via config or envvar #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Mar 8, 2023
config/initializers/rack-attack.rb
Outdated
| # don't throttle requests with a q, because it's more likely to be a real user | ||
| next if req.params['q'].present? | ||
| # throttle bot-like search queries if configured | ||
| if ActiveModel::Type::Boolean.new.cast(ENV.fetch("THROTTLE_SEARCHES", Settings.throttle_searches)) |
There was a problem hiding this comment.
How about using SETTINGS__THROTTLE_SEARCHES as the env var? Then we can just do Settings.throttle_searches. The config gem can cast to boolean and load from ENV vars if properly configured.
See https://github.com/sul-dlss/dlme/blob/main/config/initializers/config.rb#L15-L24
We'd also want to set env_parse_values = true https://github.com/sul-dlss/dlme/blob/main/config/initializers/config.rb#L34
There was a problem hiding this comment.
Testing using the console and this worked exactly how I'd expect...pretty cool. made the change
thatbudakguy
force-pushed
the
configurable-throttle
branch
from
df42103 to
7e90fe8
Compare
jcoyne
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1572
Since this sets the default to disabling search throttling, we can test that it's working correctly and then file a PR in puppet to set
THROTTLE_SEARCHESto true for prod only to re-enable it in that environment. After that I think the issue can be closed.