Add basic typography styles for common elements #49
Conversation
This adds basic styles for headers, paragraphs, and definition lists. Closes #44
| @@ -64,11 +64,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| .h1 { | |||
| font-size: 2.25rem; | |||
There was a problem hiding this comment.
no longer needed since it's the default
| @@ -5,3 +5,65 @@ | |||
| --font-family-serif: "Source Serif 4", serif; | |||
| --bs-font-sans-serif: "Source Sans 3", "Source Sans Pro"; | |||
| } | |||
|
|
|||
| h1, .h1 { | |||
| font-size: 2.25rem; | |||
There was a problem hiding this comment.
I think we are supposed to keep the responsive text size for screens below 1200px, but I am not 100% sure about this.
There was a problem hiding this comment.
Ah – so all of this (except the parts that say "xs" and "xl", maybe?) would be for <= 1200px only?
There was a problem hiding this comment.
I think we are supposed to do both, i.e.
less than 1200px responsive text sizes with the new variables (i.e. H1 gets calculated with 2.25rem not 2.5rem)
greater than 1200px fixed font where it is 2.25rem not 2.5rem
But honestly this ticket was kind of confusing to me. I think @jcoyne has a better handle than I do.
There was a problem hiding this comment.
Yes, it was my understanding that we would continue to have responsive text sizes.
There was a problem hiding this comment.
Are the responsive sizes defined somewhere else? Do I just need to put most of these changes behind a breakpoint?
| @@ -5,3 +5,65 @@ | |||
| --font-family-serif: "Source Serif 4", serif; | |||
| --bs-font-sans-serif: "Source Sans 3", "Source Sans Pro"; | |||
| } | |||
|
|
|||
| h1, .h1 { | |||
| font-size: 2.25rem; | |||
There was a problem hiding this comment.
Yes, it was my understanding that we would continue to have responsive text sizes.
This adds basic styles for headers, paragraphs, and definition
lists.
Closes #44