Decouple preview_filmstrip from async_collection members #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
decouple-filmstrip
branch
from
7986ac0 to
92bce13
Compare
jcoyne
force-pushed
the
decouple-filmstrip
branch
2 times, most recently
from
a59e7e3 to
e387795
Compare
corylown
approved these changes
Jan 29, 2024
|
@jcoyne approved, but needs rebase. |
Accomplished by using stimulus. This automatically binds to 'data-controller' when a node is added to a document. This allows us to remove the coupling with async_collection_members.
jcoyne
force-pushed
the
decouple-filmstrip
branch
from
e387795 to
1ab35c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accomplished by using stimulus. Stimulus automatically binds to 'data-controller' when a node is added to a document. This allows us to remove the coupling with async_collection_members.