Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to reflect change in markup #3745

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix tests to reflect change in markup #3745

merged 1 commit into from
Jan 17, 2024

Conversation

taylor-steve
Copy link
Contributor

Fixes some tests that failed locally but were excluded from CI.

Fix wrapping for sort-and-per-page toolbar at smaller viewports · sul-dlss/SearchWorks@52a0eff (github.com) removed the .search-widgets class. .sort-and-per-page seems to be the logical choice as the next container that wraps the same elements.

Fix multiple citations · sul-dlss/SearchWorks@9c5353c (github.com) changes the 'By citation format' from a link to a button, the test expects a link.

I didn't confirm the exact commit, but it seems that the facet also switched from a link to a button.

@taylor-steve taylor-steve marked this pull request as ready for review January 17, 2024 22:53
@jcoyne jcoyne merged commit d0e00e2 into main Jan 17, 2024
4 checks passed
@jcoyne jcoyne deleted the fix-ci-excluded-tests branch January 17, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants