-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1515 from sul-dlss/1372-hoover-links
Change request links for Hoover Library Links to use Aeon/OpenURL
- Loading branch information
Showing
11 changed files
with
508 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| class HooverOpenUrlRequest | ||
| delegate :to_param, to: :as_params | ||
| delegate :safe_join, :solr_document_url, to: :view_context | ||
| def initialize(library, document, view_context) | ||
| @library = library | ||
| @document = document | ||
| @view_context = view_context | ||
| end | ||
|
|
||
| def to_url | ||
| "#{base_url}&#{to_param}" | ||
| end | ||
|
|
||
| def as_params | ||
| { | ||
| 'ItemInfo5' => record_url, 'ReferenceNumber' => ckey, | ||
| 'ItemTitle' => item_title, 'ItemAuthor' => item_author, | ||
| 'ItemDate' => item_date, 'ItemPublisher' => item_publisher, | ||
| 'ItemPlace' => item_place, 'ItemEdition' => item_edition, | ||
| 'ItemInfo2' => item_restrictions, 'ItemInfo3' => item_conditions, | ||
| 'Value' => request_type | ||
| }.reject { |_, v| v.blank? } | ||
| end | ||
|
|
||
| def request_type | ||
| return 'GenericRequestManuscript' if archive? | ||
| 'GenericRequestMonograph' | ||
| end | ||
|
|
||
| def record_url | ||
| solr_document_url(document) | ||
| end | ||
|
|
||
| def ckey | ||
| document[:id] | ||
| end | ||
|
|
||
| def item_title | ||
| marc_data(field_codes: '245', subfield_codes: %w[a b n p]) | ||
| end | ||
|
|
||
| def item_author | ||
| author_fields = { | ||
| '100' => %w[a b c d q], '110' => %w[a b c d], | ||
| '111' => %w[a c d], '130' => %w[a d f n p] | ||
| } | ||
|
|
||
| author_fields.each do |field_codes, subfield_codes| | ||
| data = marc_data(field_codes: field_codes, subfield_codes: subfield_codes) | ||
| return data if data.present? | ||
| end | ||
| nil # return nil if none of the fields matched | ||
| end | ||
|
|
||
| def item_date | ||
| return unless archive? | ||
| marc_data(field_codes: '245', subfield_codes: ['f']) | ||
| end | ||
|
|
||
| def item_publisher | ||
| return if archive? | ||
| marc_260 = marc_data(field_codes: '260', subfield_codes: %w[a b c]) | ||
| marc_264 = marc_data(field_codes: '264', subfield_codes: %w[a b c]) | ||
| safe_join([marc_260, marc_264], ' ') | ||
| end | ||
|
|
||
| def item_place | ||
| marc_data(field_codes: '300', subfield_codes: %w[a b c f]) | ||
| end | ||
|
|
||
| def item_edition | ||
| return if archive? | ||
| marc_data(field_codes: '250', subfield_codes: ['a']) | ||
| end | ||
|
|
||
| def item_restrictions | ||
| marc_data(field_codes: '506', subfield_codes: %w[3 a]) | ||
| end | ||
|
|
||
| def item_conditions | ||
| return unless archive? | ||
| marc_data(field_codes: '540', subfield_codes: %w[3 a]) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| attr_reader :library, :document, :view_context | ||
|
|
||
| def archive? | ||
| library == 'HV-ARCHIVE' | ||
| end | ||
|
|
||
| def marc | ||
| document.to_marc | ||
| end | ||
|
|
||
| def marc_data(field_codes:, subfield_codes:) | ||
| field_code = marc_field_code_for_present_data(field_codes: field_codes, subfield_codes: subfield_codes) | ||
| return unless field_code | ||
|
|
||
| safe_join(marc[field_code].subfields.map do |subfield| | ||
| next unless subfield_codes.include?(subfield.code) | ||
| subfield.value | ||
| end.compact, ' ') | ||
| end | ||
|
|
||
| def marc_field_code_for_present_data(field_codes:, subfield_codes:) | ||
| Array.wrap(field_codes).find do |code| | ||
| marc[code].present? && marc[code].subfields.any? { |subfield| subfield_codes.include?(subfield.code) } | ||
| end | ||
| end | ||
|
|
||
| def base_url | ||
| Settings.HOOVER_REQUESTS_URL | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| require 'spec_helper' | ||
|
|
||
| describe 'Request Links', type: :feature do | ||
| describe 'Hoover links' do | ||
| context 'in search results' do | ||
| it 'renders a link to the detail/record view instead of holdings' do | ||
| visit search_catalog_path(q: '56') | ||
|
|
||
| within 'table.availability' do | ||
| expect(page).not_to have_content 'ABC 123' | ||
|
|
||
| expect(page).to have_link 'See full record for details' | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'on the record view' do | ||
| it 'renders a request button at the location level' do | ||
| visit solr_document_path '56' | ||
|
|
||
| expect(page).to have_css('.request-button', text: 'Request on-site access') | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| :id: 56 | ||
| :title_display: Hoover Item | ||
| :format_main_ssim: Map | ||
| :marcxml: <%= hoover_request_fixture %> | ||
| :marcbib_xml: <%= hoover_request_fixture %> | ||
| :item_display: | ||
| - "123 -|- HOOVER -|- STACKS -|- -|- -|- -|- -|- -|- ABC 123" |
Oops, something went wrong.