✨(dimail) get domain specification for DNS config #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdemagny
force-pushed
the
sdem/spec
branch
8 times, most recently
from
14261aa to
7440711
Compare
|
Je n'ai pas tout à fait fini les tests... la review peut un peu attendre |
sdemagny
force-pushed
the
sdem/spec
branch
8 times, most recently
from
581fe50 to
7f3650f
Compare
|
J'ai 3 commits à la fin qui seront squashé si c'est ok, qui correspondent à du renommage. Je préfère les laisser comme ça si suite à la review c'était mieux la première version |
qbey
reviewed
Feb 14, 2025
| """Return expected config of the domain.""" | ||
| if domain.status == enums.MailDomainStatusChoices.ACTION_REQUIRED: | ||
| client = DimailAPIClient() | ||
| return client.get_domain_expected_config(domain) |
There was a problem hiding this comment.
I'm not sure we want a call to be triggered everytime + on list view it will be chaos.
sdemagny
force-pushed
the
sdem/spec
branch
2 times, most recently
from
954d060 to
602e803
Compare
Add missing migration after define ordering by created_at for Mailbox, MailDomain and MailDomainAccess by created_at.
Call dimail to get all the DNS configuration values to make an external domain work and save it in our db. Add the value to serializer for displaying.
Display DNS configuration required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call dimail to get all the DNS configuration values to make an external domain work.
TODO:
Premier jet en attente d'une maquette de cette page:
Il reste un comportement bizarre avec le toaster il ne se met pas en premier plan avec la modal affichée.
Un fix à faire sur cunningham un jour peut être (@elvoisin)