Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend adjustements #35

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Frontend adjustements #35

merged 3 commits into from
Jul 17, 2024

Conversation

lebaudantoine
Copy link
Collaborator

Purpose

Minor changes.
Nothing special, only nit-picking / refactoring.

Use the function introduce by @manuhabitela, authUrl.
It reduces code duplication.
No big deal, just a little nit-pick. Nothing personal!
My IDE is THE nit-picker.
Wrap the logout URL in a function for consistency with '/authenticate'.
Copy link
Contributor

@manuhabitela manuhabitela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lebaudantoine lebaudantoine marked this pull request as ready for review July 17, 2024 14:51
@lebaudantoine lebaudantoine merged commit 6e20d53 into main Jul 17, 2024
6 of 8 checks passed
@lebaudantoine lebaudantoine deleted the refacto-frontend branch July 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants