🩹(frontend) prevent runtime error when Crisp is not initialized #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
commented
Jan 22, 2025
Comment on lines
+10
to
+12
| const [isOpened, setIsOpened] = useState(() => { | ||
| return window?.$crisp?.is?.('chat:opened') || false | ||
| }) |
There was a problem hiding this comment.
afterthought, should we hide the toggle if crisp isn't defined. I'm scared it would cause layout shifts;
There was a problem hiding this comment.
My review comment reply to this in an indirect way
NathanVss
reviewed
Jan 27, 2025
There was a problem hiding this comment.
It seems it may sometimes caused by a race condition due to network speed. I do not find it nice to set it closed only because we are not waiting for $crisp to be fully loaded.
But in the same time I can't find a way to "wait for $crisp to be loaded" in the officiel doc here: https://docs.crisp.chat/guides/chatbox-sdks/web-sdk/dollar-crisp/
WDYT?
EDIT: Maybe "https://docs.crisp.chat/guides/chatbox-sdks/web-sdk/dollar-crisp/" "Session has loaded" ?
Prevents runtime error when Crisp chat hasn't initialized before component mount Previously caused crash since we assumed $crisp global was always available.
lebaudantoine
force-pushed
the
fix-crisp
branch
from
9a84a2c to
eb467d9
Compare
Avoid misleading the user, if support is not enabled, as it's optional, avoid displaying a useless control button. Requested by Dutch counterparts.
lebaudantoine
force-pushed
the
fix-crisp
branch
from
4903534 to
0d00be4
Compare
|
It closes #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents runtime error when Crisp chat hasn't initialized before component mount Previously caused crash since we assumed $crisp global was always available.