Allow custom room names #315
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| import { FormEvent, useState } from 'react' | ||
| import { useTranslation } from 'react-i18next' | ||
| import { Button, Dialog, type DialogProps, Text } from '@/primitives' | ||
| import { HStack } from '@/styled-system/jsx' | ||
| import { RiSpam2Fill } from '@remixicon/react' | ||
| import { navigateTo } from '@/navigation/navigateTo.ts' | ||
| import { useCreateRoom } from '@/features/rooms' | ||
| import { | ||
| FieldError, | ||
| Form as RACForm, | ||
| Input, | ||
| Label, | ||
| TextField, | ||
| } from 'react-aria-components' | ||
| import { css } from '@/styled-system/css' | ||
| import { | ||
| MIN_ROOM_LENGTH, | ||
| ALPHANUMERIC_LOWERCASE, | ||
| } from '@/features/rooms/utils/isRoomValid' | ||
|
|
||
| export const PersonalizeMeetingDialog = ({ | ||
| isOpen, | ||
| ...dialogProps | ||
| }: Omit<DialogProps, 'title'>) => { | ||
| const { t } = useTranslation('home', { | ||
| keyPrefix: 'personalizeMeetingDialog', | ||
| }) | ||
| const { mutateAsync: createRoom } = useCreateRoom() | ||
| const [roomSlug, setRoomSlug] = useState('') | ||
| const [serverErrors, setServerErrors] = useState<Array<string>>([]) | ||
|
|
||
| const onSubmit = (e: FormEvent<HTMLFormElement>) => { | ||
| e.preventDefault() | ||
| createRoom({ slug: roomSlug }) | ||
| .then((data) => | ||
| navigateTo('room', data.slug, { | ||
| state: { create: true, initialRoomData: data }, | ||
| }) | ||
| ) | ||
| .catch((e) => { | ||
| const msg = | ||
| e.statusCode === 400 | ||
|
There was a problem hiding this comment. Related to my comment about error names: what if there are multiple possible errors with the same http code? Not to fix now ofc |
||
| ? t('errors.server.taken') | ||
| : t('errors.server.unknown') | ||
| setServerErrors([msg]) | ||
| }) | ||
| } | ||
|
|
||
| const validationErrors = [] | ||
| if (roomSlug.length < MIN_ROOM_LENGTH) { | ||
| validationErrors.push(t('errors.validation.length')) | ||
| } | ||
| if (!new RegExp(`^${ALPHANUMERIC_LOWERCASE}+$`).test(roomSlug)) { | ||
| validationErrors.push(t('errors.validation.spaceOrSpecialCharacter')) | ||
| } | ||
|
|
||
| const errors = [...validationErrors, ...serverErrors] | ||
|
|
||
| return ( | ||
| <Dialog isOpen={!!isOpen} {...dialogProps} title={t('heading')}> | ||
|
There was a problem hiding this comment. Broader subject (out of scope): on mobile I tend to think having a full screen modal with its content being aligned on top is more UX. Mobile user are more used to panes-like navigation. 
There was a problem hiding this comment. Agree, we have a poor mobile UX. |
||
| <RACForm onSubmit={onSubmit}> | ||
| <TextField | ||
| isRequired | ||
| isInvalid={errors.length > 0} | ||
| value={roomSlug} | ||
| onChange={(e) => { | ||
| setServerErrors([]) | ||
| setRoomSlug(e.toLowerCase()) | ||
| }} | ||
| className={css({ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| })} | ||
| > | ||
| <Label>{t('label')}</Label> | ||
| <div | ||
| className={css({ | ||
| display: 'flex', | ||
| justifyContent: 'space-between', | ||
| })} | ||
| > | ||
| <Input | ||
| className={css({ | ||
| height: '46px', | ||
| border: '1px solid black', | ||
| padding: '4px 8px', | ||
| width: '80%', | ||
| borderRadius: '0.25rem', | ||
| })} | ||
| placeholder={t('placeholder')} | ||
| /> | ||
| <Button type="submit">{t('submit')}</Button> | ||
| </div> | ||
| <div | ||
| className={css({ | ||
| minHeight: '72px', | ||
| })} | ||
| > | ||
| <FieldError> | ||
| <ul | ||
| className={css({ | ||
| listStyle: 'square inside', | ||
| color: 'red', | ||
| marginLeft: '10px', | ||
| marginTop: '10px', | ||
| })} | ||
| > | ||
| {errors.map((error, i) => ( | ||
| <li key={i}> | ||
| <Text as="span" variant={'sm'}> | ||
| {error} | ||
| </Text> | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| </FieldError> | ||
| </div> | ||
| </TextField> | ||
| </RACForm> | ||
|
|
||
| <HStack> | ||
| <div | ||
| style={{ | ||
| backgroundColor: '#d9e5ff', | ||
| borderRadius: '50%', | ||
| padding: '4px', | ||
| marginTop: '1rem', | ||
| }} | ||
| > | ||
| <RiSpam2Fill size={22} style={{ fill: '#4c84fc' }} /> | ||
| </div> | ||
| <Text variant="sm" style={{ marginTop: '1rem', textWrap: 'balance' }}> | ||
| {t('warning')} | ||
| </Text> | ||
| </HStack> | ||
| </Dialog> | ||
| ) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have overlooked something in the React Aria documentation, but this is the approach I found to prevent a HTML form from being submitted and navigating to a URL suffixed with a question mark.