-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(front) revamp pre join screen #305
Conversation
55d9a4d
to
bb53e61
Compare
This transition feels glitchy. Also when I long press the Camera toggle button, only the shadow are shown for ~1s. let's show you IRL Enregistrement.de.l.ecran.2025-01-18.a.22.21.04.movEnregistrement.de.l.ecran.2025-01-18.a.22.28.11.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a product-oriented review. Will review the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would remove the debug code tbh !
src/frontend/src/features/rooms/livekit/components/controls/ToggleDevice.tsx
Show resolved
Hide resolved
src/frontend/src/features/rooms/livekit/components/controls/SelectToggleDevice.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/features/rooms/livekit/components/controls/SelectToggleDevice.tsx
Show resolved
Hide resolved
We want to be able to change the variant of this component.
We want to be able to provide some custom attributes to the FieldWrapper and its label too to manage width, alignment.
This component is needed on the join screen thus out of a room context.
We want this screen to have a better ux, the join button was invisible on some small screen sizes, also we want to align the style of this screen with the ui of the video conference previously made.
Purpose
The previous prejoin screenshot was misleading for some screen size, for small screen the join button was invisible + we want to align with the most up to date styles we use.
Proposal
Resizing
Mon.film.1.mp4
On small desktop screens
Before
Todo