Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(front) revamp pre join screen #305

Merged
merged 4 commits into from
Jan 27, 2025
Merged

✨(front) revamp pre join screen #305

merged 4 commits into from
Jan 27, 2025

Conversation

NathanVss
Copy link
Collaborator

@NathanVss NathanVss commented Jan 15, 2025

Purpose

The previous prejoin screenshot was misleading for some screen size, for small screen the join button was invisible + we want to align with the most up to date styles we use.

Proposal

Capture d’écran 2025-01-15 à 17 18 43

Resizing

Mon.film.1.mp4

On small desktop screens

Capture d’écran 2025-01-15 à 17 42 39

Before

Capture d’écran 2025-01-15 à 17 19 05 Capture d’écran 2025-01-15 à 17 43 35

Todo

  • Delete TextFieldWrapper, voir implications
  • Gestion des tracks
  • Devices are disabled by default
  • Utilisation ToggleDevice en dehors d'une Room
  • Camera disabled blanc
  • disabled button

@NathanVss NathanVss changed the title ✨(front) revamp pre join screen WIP ✨(front) revamp pre join screen Jan 15, 2025
@lebaudantoine
Copy link
Collaborator

wow, nice job, already x10 times better.
I would break the row into column slightly before, at this moment.

Capture d’écran 2025-01-15 à 22 26 47

@lebaudantoine
Copy link
Collaborator

Also, nit-picking comments incoming:

Given and family names are rarely longer than 20–25 characters. Could we reduce the input size (label n°1 in my drawing), particularly when the screen width starts to shrink? This adjustment would help maintain the initial proportions between the left and right columns, which are visually perfect and very satisfying.

(do you like having the input's max size visually displayed?)

Really nit-picking here, but I love the (almost) visual alignment between the title and the CTA (label n°2 in my drawing). I’m not sure if it was intentional, but the button’s smaller width compared to the input makes the input feel like it’s floating on a cloud.

Capture d’écran 2025-01-15 à 22 29 18

@NathanVss
Copy link
Collaborator Author

Also, nit-picking comments incoming:

Given and family names are rarely longer than 20–25 characters. Could we reduce the input size (label n°1 in my drawing), particularly when the screen width starts to shrink? This adjustment would help maintain the initial proportions between the left and right columns, which are visually perfect and very satisfying.

(do you like having the input's max size visually displayed?)

Really nit-picking here, but I love the (almost) visual alignment between the title and the CTA (label n°2 in my drawing). I’m not sure if it was intentional, but the button’s smaller width compared to the input makes the input feel like it’s floating on a cloud.

Capture d’écran 2025-01-15 à 22 29 18

Here are three propositions that we coud discuss:

1

Capture d’écran 2025-01-16 à 11 24 21

2

Capture d’écran 2025-01-16 à 11 24 18

3

Capture d’écran 2025-01-16 à 11 24 15

My personal order of preference: 2 3 1

@NathanVss NathanVss force-pushed the feat/join branch 2 times, most recently from 55d9a4d to bb53e61 Compare January 16, 2025 13:57
@NathanVss NathanVss changed the title WIP ✨(front) revamp pre join screen ✨(front) revamp pre join screen Jan 16, 2025
@lebaudantoine
Copy link
Collaborator

Enhancement: Display an explicit message when camera is disabled instead of an avatar?

Capture d’écran 2025-01-18 à 22 28 38

@lebaudantoine
Copy link
Collaborator

When I open the camera selector, even if my camera is opened, I have no option selected.

Capture d’écran 2025-01-18 à 22 26 49

@lebaudantoine
Copy link
Collaborator

Bug: I type my name, then type enter. It submits a form, I navigate to the same URL with ? appended at the end.

Capture d’écran 2025-01-18 à 22 26 19

@lebaudantoine
Copy link
Collaborator

error message should be internationalized
Capture d’écran 2025-01-18 à 22 25 24

@lebaudantoine
Copy link
Collaborator

Enhancement: I would suggest limiting the field to 50/60 chars, I just entered the room with a 200 char name, it feels weird.

Capture d’écran 2025-01-18 à 22 24 38

@lebaudantoine
Copy link
Collaborator

Question: is that field still pre-filled with username given by ProConnect if no previous one was persisted in local storage?

Capture d’écran 2025-01-18 à 22 22 31

@lebaudantoine
Copy link
Collaborator

Introducing Marianne caused several text elements in the app to appear excessively small. Let's address this to enhance accessibility.

Capture d’écran 2025-01-18 à 22 19 02 Capture d’écran 2025-01-18 à 22 19 02

@lebaudantoine
Copy link
Collaborator

Nit-picking: with Marianne, the heading title is bigger, and doesn't fit on two lines properly.

Capture d’écran 2025-01-18 à 22 17 32

@lebaudantoine
Copy link
Collaborator

Question: Should we align left this element?

Capture d’écran 2025-01-18 à 22 20 22

@lebaudantoine
Copy link
Collaborator

lebaudantoine commented Jan 18, 2025

This transition feels glitchy. Also when I long press the Camera toggle button, only the shadow are shown for ~1s. let's show you IRL

Enregistrement.de.l.ecran.2025-01-18.a.22.21.04.mov
Enregistrement.de.l.ecran.2025-01-18.a.22.28.11.mov

@lebaudantoine
Copy link
Collaborator

Camera is reverse, and switch back in the right orientation when entering the room

Capture d’écran 2025-01-18 à 22 19 36

Copy link
Collaborator

@lebaudantoine lebaudantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a product-oriented review. Will review the code

@NathanVss
Copy link
Collaborator Author

Question: is that field still pre-filled with username given by ProConnect if no previous one was persisted in local storage?

Capture d’écran 2025-01-18 à 22 22 31

It is based on "user?.full_name" as before, so it is supposed to be pre-set

@NathanVss
Copy link
Collaborator Author

Question: Should we align left this element?

Capture d’écran 2025-01-18 à 22 20 22

We already said that we go for option 2 ( with text centered )

Copy link
Collaborator

@lebaudantoine lebaudantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would remove the debug code tbh !

We want to be able to change the variant of this component.
We want to be able to provide some custom attributes to the FieldWrapper
and its label too to manage width, alignment.
This component is needed on the join screen thus out of a room context.
We want this screen to have a better ux, the join button was invisible on
some small screen sizes, also we want to align the style of this screen with
the ui of the video conference previously made.
@NathanVss NathanVss merged commit 7f1f573 into main Jan 27, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants