♻️Stop setting a default title on doc creation #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/let-empty-title
branch
2 times, most recently
from
b45cadc to
e7b620f
Compare
AntoLC
force-pushed
the
fix/let-empty-title
branch
from
e7b620f to
6738c6d
Compare
sampaccoud
approved these changes
Feb 13, 2025
src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridLoader.tsx
Show resolved
Hide resolved
AntoLC
force-pushed
the
fix/let-empty-title
branch
from
6738c6d to
2dac4a6
Compare
- fix linter warning on one e2e test - improve logo svg - improve cursor - improve grid loader
We were setting a default title to our document during creation, but we should not do that, it created lot of similar titles, lot of documents will show up during search.
Add django-test-migrations to the project. It is a tool that helps to test Django migrations.
The frontend was setting a default titles for documents with empty titles. This migration updates the document table to set the title to null instead of the default title. We add a test to ensure that the migration works as expected.
AntoLC
force-pushed
the
fix/let-empty-title
branch
from
2dac4a6 to
6888586
Compare
Previous commit add "core/tests/migrations". The linter could not pass on it because all the migration folders were excluded from the linter. We remove this exclusion, tests and migrations can now be linted and formatted automatically.
AntoLC
force-pushed
the
fix/let-empty-title
branch
from
6888586 to
82417c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We were setting a default title to our document during creation, but we should not do that, it created lot of similar titles, lot of documents will show up during search.
Proposal